perf: Optimize NULL handling in some datetime functions#21477
Merged
mbutrovich merged 2 commits intoapache:mainfrom Apr 10, 2026
Merged
perf: Optimize NULL handling in some datetime functions#21477mbutrovich merged 2 commits intoapache:mainfrom
mbutrovich merged 2 commits intoapache:mainfrom
Conversation
mbutrovich
approved these changes
Apr 10, 2026
|
|
||
| let mut builder: PrimitiveBuilder<Time32SecondType> = | ||
| PrimitiveArray::builder(len); | ||
| let nulls = NullBuffer::union( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
to_time,to_local_time, andmake_datebuild NULLs arrays incrementally. It is faster and more idiomatic to build them in bulk viaNullBufferinstead.This doesn't make a huge performance difference in practice, but it shouldn't be slower, and the result is more concise and idiomatic.
Benchmarks (ARM64):
What changes are included in this PR?
to_timeandto_local_timemake_datebenchmark, for consistency with default DF batch sizeAre these changes tested?
Yes.
Are there any user-facing changes?
No.